From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 02/09] drm/i915: try to train DP even harder
Date: Thu, 12 Jul 2012 16:58:13 +0200
Message-ID: <20120712145813.GI5039@phenom.ffwll.local>
References: <1340996621-14345-1-git-send-email-przanoni@gmail.com>
	<1340996621-14345-2-git-send-email-przanoni@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-we0-f177.google.com (mail-we0-f177.google.com
	[74.125.82.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id 62BDC9E769
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 12 Jul 2012 07:58:12 -0700 (PDT)
Received: by weyr3 with SMTP id r3so1786573wey.36
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 12 Jul 2012 07:58:11 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1340996621-14345-2-git-send-email-przanoni@gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni <paulo.r.zanoni@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Jun 29, 2012 at 04:03:34PM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> 
> While debugging Haswell link train failures I observed that we never
> try the maximum voltage configuration more than once consecutively. We
> start the training, the monitor keeps telling us to increase the
> voltage, then when we reach the maximum we just go back to the start
> (because of the "memset" above "voltage_tries = 0"). When we reach
> this point, we keep alternating between the maximum and the minimum
> voltages until we give up.
> 
> The DP spec suggests that we should try the same voltage 5 times
> before giving up. This patch makes us try the maximum voltage at
> least 5 times before going back to the minimum voltages.
> 
> This patch does not fix any particular bug I'm aware of.
> 
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

Gosh, this is the most convoluted loop flattening code I've ever seen.
Patch queued for -next, thanks.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48