Re: [PATCH 00/81] modeset rework

Chris Wilson
2012-07-15T13:14:02Z

On Wed, 11 Jul 2012 16:27:43 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Or: How to fix cpu edp in 81 simple steps. Admittedly this includes some minor
> detours.

Let me quickly jump in with my demands:

That modeset should detect failure and propagate that back to the user.

The modesetting code has outgrown its origins of setting a couple of
registers and be done, as we are now in the domain of fiddly link
training and end-point negotations. So it is fragile, can conceivably
fail and so the errors need to be reported rather than blindly assume
the output is now working.

So all of these nice new WARNs I'm seeing need to return error codes as
well.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre