From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: don't forget the PCH backlight
 registers
Date: Sat, 14 Jul 2012 18:15:31 +0200
Message-ID: <20120714161531.GD5498@phenom.ffwll.local>
References: <1342277833-3694-1-git-send-email-przanoni@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-we0-f177.google.com (mail-we0-f177.google.com
	[74.125.82.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id 88AEF9ECF7
	for <intel-gfx@lists.freedesktop.org>;
	Sat, 14 Jul 2012 09:15:29 -0700 (PDT)
Received: by weyr3 with SMTP id r3so3257254wey.36
	for <intel-gfx@lists.freedesktop.org>;
	Sat, 14 Jul 2012 09:15:28 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1342277833-3694-1-git-send-email-przanoni@gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni <paulo.r.zanoni@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Sat, Jul 14, 2012 at 11:57:12AM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> 
> When we enable/disable the CPU backlight registers we can't forget to
> enable/disable the PCH backlight registers. Since we're using the CPU
> registers we should also unset the override bit.
> 
> Fixes a regression on the following commit:
>   drm/i915: properly enable the blc controller on the right pipe
> 
> The commit just deleted the code that sets the PCH registers, so it
> was relying on the values set by the BIOS. I told my BIOS to boot on
> the DVI monitor instead of the LVDS panel, so I noticed the bug.
> 
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Ok, I've double-check bspec, and at least on ilk, snb & ivb this seems to
be a sane thing to do. Patch queued for -next, thanks.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48