From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: add port parameter to
	intel_hdmi_init
Date: Tue, 17 Jul 2012 10:43:10 +0200
Message-ID: <20120717084310.GB5498@phenom.ffwll.local>
References: <1342016944-23395-21-git-send-email-daniel.vetter@ffwll.ch>
	<1342117199-26089-1-git-send-email-daniel.vetter@ffwll.ch>
	<CA+gsUGSpQ9p0_yNwZi=MZ3sR2Lg1A6HJQKup6_E+b3N4v+q9cw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-bk0-f49.google.com (mail-bk0-f49.google.com
	[209.85.214.49])
	by gabe.freedesktop.org (Postfix) with ESMTP id C7D81A09D9
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 17 Jul 2012 01:43:06 -0700 (PDT)
Received: by bkcji2 with SMTP id ji2so99650bkc.36
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 17 Jul 2012 01:43:05 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CA+gsUGSpQ9p0_yNwZi=MZ3sR2Lg1A6HJQKup6_E+b3N4v+q9cw@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Jul 12, 2012 at 04:49:34PM -0300, Paulo Zanoni wrote:
> 2012/7/12 Daniel Vetter <daniel.vetter@ffwll.ch>:
> > Instead of having a giant if cascade to figure this out according to
> > the passed-in register. We could do quite a bit more cleaning up and
> > all by using the port at more places, but I think this should be part
> > of a bigger rework to introduce a struct intel_digital_port which
> > would keep track of all these things. I guess this will be part of
> > some haswell-DP-induced refactoring.
> >
> > For now this rips out the big cascade, which is what annoyed me so
> > much.
> >
> > v2: Add port variable name back for the func decl (I've tried to trick
> > myself below the 80 char limit).
> >
> > Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

I've merged the three patches you've reviewed already to dinq (with the
comment in patch 13 fixed up), thanks for the review.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48