From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH] intel: Don't print messages to stderr if context creation fails. Date: Tue, 17 Jul 2012 16:03:07 -0700 Message-ID: <20120717160307.16f0f633@bwidawsk.net> References: <1342122322-13938-1-git-send-email-kenneth@whitecape.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com [184.106.247.128]) by gabe.freedesktop.org (Postfix) with ESMTP id 278689EFCC for ; Tue, 17 Jul 2012 16:03:17 -0700 (PDT) In-Reply-To: <1342122322-13938-1-git-send-email-kenneth@whitecape.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Kenneth Graunke Cc: intel-gfx@lists.freedesktop.org, mesa-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, 12 Jul 2012 12:45:22 -0700 Kenneth Graunke wrote: > Since there is no getparam for hardware context support, Mesa always > tries to obtain a context by calling drm_intel_gem_context_create and > NULL-checking the result. On an older kernel without context support, > this caused libdrm to print an unwanted message to stderr: > > DRM_IOCTL_I915_GEM_CONTEXT_CREATE failed: Invalid argument > > In fact, this caused every Piglit test to fail with a "warn" status due > to the unrecognized error message. > > Simply delete the message. It's OK for context creation to fail. Change it to DBG() and you have my: Reviewed-by: Ben Widawsky > > Cc: Ben Widawsky > Cc: Paul Berry > Cc: mesa-devel@lists.freedesktop.org > Signed-off-by: Kenneth Graunke > --- > intel/intel_bufmgr_gem.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/intel/intel_bufmgr_gem.c b/intel/intel_bufmgr_gem.c > index a957c28..1b4ac78 100644 > --- a/intel/intel_bufmgr_gem.c > +++ b/intel/intel_bufmgr_gem.c > @@ -2850,11 +2850,8 @@ drm_intel_gem_context_create(drm_intel_bufmgr *bufmgr) > int tmp = 0, ret; > > ret = drmIoctl(bufmgr_gem->fd, DRM_IOCTL_I915_GEM_CONTEXT_CREATE, &create); > - if (ret != 0) { > - fprintf(stderr, "DRM_IOCTL_I915_GEM_CONTEXT_CREATE failed: %s\n", > - strerror(errno)); > + if (ret != 0) > return NULL; > - } > > context = calloc(1, sizeof(*context)); > context->ctx_id = create.ctx_id; -- Ben Widawsky, Intel Open Source Technology Center