From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2] drm/i915: add register read IOCTL Date: Wed, 18 Jul 2012 20:12:16 +0200 Message-ID: <20120718181216.GL5348@phenom.ffwll.local> References: <1342051656-32481-1-git-send-email-ben@bwidawsk.net> <1342116066-12164-1-git-send-email-ben@bwidawsk.net> <87pq7txa7t.fsf@eliezer.anholt.net> <20120718102201.3d1b0b57@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 9E70CA0E2C for ; Wed, 18 Jul 2012 11:12:12 -0700 (PDT) Received: by weyr3 with SMTP id r3so1245310wey.36 for ; Wed, 18 Jul 2012 11:12:11 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20120718102201.3d1b0b57@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Jul 18, 2012 at 10:22:01AM -0700, Ben Widawsky wrote: > On Wed, 18 Jul 2012 10:14:46 -0700 > Eric Anholt wrote: > > > Ben Widawsky writes: > > > > > The interface's immediate purpose is to do synchronous timestamp queries > > > as required by GL_TIMESTAMP. The GPU has a register for reading the > > > timestamp but because that would normally require root access through > > > libpciaccess, the IOCTL can provide this service instead. > > > > > > Currently the implementation whitelists only the render ring timestamp > > > register, because that is the only thing we need to expose at this time. > > > > > > v2: make size implicit based on the register offset > > > Add a generation check > > > > > diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h > > > index 8cc7083..fbe7757 100644 > > > --- a/include/drm/i915_drm.h > > > +++ b/include/drm/i915_drm.h > > > @@ -203,6 +203,7 @@ typedef struct _drm_i915_sarea { > > > #define DRM_I915_GEM_WAIT 0x2c > > > #define DRM_I915_GEM_CONTEXT_CREATE 0x2d > > > #define DRM_I915_GEM_CONTEXT_DESTROY 0x2e > > > +#define DRM_I915_REG_READ 0x30 > > > > Is 0x2f some other outstanding ioctl? > > > > I was saving it for some yet to be realized context ioctl. We can use > 0x2f, I don't care. Daniel - feel free to change it or not as you > please when/if you suck it in. Patch queued for -next (with ioctl number 0x31, I've figure when I'll change it I might as well avoid conflicts with the set_cacheing stuff). Can you please adjust the i-g-t test and commit that one, too? Thanks, Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48