From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 9/9] drm/i915: enable rc6 on ilk again Date: Wed, 25 Jul 2012 14:26:26 -0700 Message-ID: <20120725142626.479858f6@bwidawsk.net> References: <1343165630-21604-1-git-send-email-daniel.vetter@ffwll.ch> <1343165630-21604-10-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com [184.106.247.128]) by gabe.freedesktop.org (Postfix) with ESMTP id 0A5D5A0DC5 for ; Wed, 25 Jul 2012 14:26:33 -0700 (PDT) In-Reply-To: <1343165630-21604-10-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Tue, 24 Jul 2012 23:33:50 +0200 Daniel Vetter wrote: > I have the faint hope that the total absence of any locking for the > rps code wasn't too good an idea and could very well have caused some > rc6 related regressions. > > Unfortunately we've never managed to reproduce these issues on any of > our own machines, so the only way to go about this is to enable it and > see what happens. > > While at it, kill some stale comments and improve the logging. > > Signed-Off-by: Daniel Vetter Here as with the previous patch, I don't think it belongs in the series.