From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 8/9] drm/ips: move drps/ips/ilk related
 variables into dev_priv->ips
Date: Wed, 25 Jul 2012 23:32:16 +0200
Message-ID: <20120725213216.GH5396@phenom.ffwll.local>
References: <1343165630-21604-1-git-send-email-daniel.vetter@ffwll.ch>
	<1343165630-21604-9-git-send-email-daniel.vetter@ffwll.ch>
	<20120725142520.6862b734@bwidawsk.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-we0-f177.google.com (mail-we0-f177.google.com
	[74.125.82.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id 3DDE89ED24
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 25 Jul 2012 14:32:08 -0700 (PDT)
Received: by weyr3 with SMTP id r3so945181wey.36
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 25 Jul 2012 14:32:07 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20120725142520.6862b734@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Ben Widawsky <ben@bwidawsk.net>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Jul 25, 2012 at 02:25:20PM -0700, Ben Widawsky wrote:
> On Tue, 24 Jul 2012 23:33:49 +0200
> Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> 
> > Like with the equivalent change for gen6+ rps state, this helps in
> > clarifying the code (and in fixing a few places that have fallen through
> > the cracks in the locking review).
> > 
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> I don't think this patch is necessary, and doesn't belong in the series.
> The series was about fixing a locking problem. If you want to submit
> this as a separate patch, I'd prefer it.
> 
> If you're really determined to keep it, I'd roll it into the earlier
> patches that did the rps renaming.

Well, you've already smashed your r-b onto the equivalent patch for the
gen6+ rps code. But the real reason this belongs to this series is that
I've used this rename (and the rps one) to actually figure out (with the
help of the compiler) what is actually touched where and which parts
belong together. 'Cause the current code is a rather decent mess.

-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48