From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier Galibert Subject: Re: [Mesa-dev] [PATCH 1/9] intel gen4-5: fix the vue view in the fs. Date: Fri, 27 Jul 2012 11:21:27 +0200 Message-ID: <20120727092127.GB31286@dspnet.fr> References: <1342728024-15055-1-git-send-email-galibert@pobox.com> <1342728024-15055-2-git-send-email-galibert@pobox.com> <874nouqw52.fsf@eliezer.anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <874nouqw52.fsf@eliezer.anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Eric Anholt Cc: mesa-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Jul 26, 2012 at 10:18:01AM -0700, Eric Anholt wrote: > Olivier Galibert writes: > > > In some cases the fragment shader view of the vue registers was out of > > sync with the builder. This fixes it. > > s/builder/SF outputs/ ? > > I'd love to see the pre-gen6 code get rearranged so the FS walked the > bitfield of FS inputs from SF and chose the urb offset for each. But > this does look like the minimal fix. In other words, an explicit linking pass? That could be useful with geometry shaders, too. OG.