From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: Fwd: Re: Macbook Pro Retina display problems Date: Mon, 6 Aug 2012 21:31:25 +0200 Message-ID: <20120806193125.GA25373@phenom.ffwll.local> References: <5019E550.40608@mso.anu.edu.au> <5019F5E1.3090305@gmail.com> <20120806071259.GD5502@phenom.ffwll.local> <501F878E.8090001@gmail.com> <501FC954.3080300@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id 30D6D9E853 for ; Mon, 6 Aug 2012 12:32:27 -0700 (PDT) Received: by wgbdr1 with SMTP id dr1so2520945wgb.12 for ; Mon, 06 Aug 2012 12:32:27 -0700 (PDT) Content-Disposition: inline In-Reply-To: <501FC954.3080300@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Francois Rigaut Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Aug 06, 2012 at 11:40:36PM +1000, Francois Rigaut wrote: > Daniel, > > On Mon, Aug 6, 2012 at 7:17 PM, Daniel Vetter > wrote: > > On Mon, Aug 6, 2012 at 10:59 AM, Francois Rigaut > wrote: > > Daniel, > > > > > > my bad for the dmesg. It's there: > > > http://maumae.net/retina/intel_corrupted_drm_debug/dmesg_intel_corrupted_drm_debug > > > > I took pictures with a camera, and uploaded them at > > Small 800x600 versions: > > > http://maumae.net/retina/intel_corrupted_drm_debug/intel_corrupted_upper_left_small.jpg > > > http://maumae.net/retina/intel_corrupted_drm_debug/intel_corrupted_upper_right_small.jpg > > > > > > http://maumae.net/retina/intel_corrupted_drm_debug/intel_corrupted_whole_screen_small.jpg > > > > > full resolution versions: > > > http://maumae.net/retina/intel_corrupted_drm_debug/intel_corrupted_upper_left.jpg > > > > > > http://maumae.net/retina/intel_corrupted_drm_debug/intel_corrupted_upper_right.jpg > > > > > > http://maumae.net/retina/intel_corrupted_drm_debug/intel_corrupted_whole_screen.jpg > > > > > > > Otherwise, the display works and behave normally (it's not > static, doesn't > > flicker). I can interact normally with the GUI element, display > stuff, it's > > accelerated (I run compiz and window wiggle normally, I can play > videos, I > > have control of backlight, etc). > > Wow, that's a pretty impressive light-show ;-) Are the wrong colors > always wrong in this manner, or does it change from boot to boot? > > > everything (color and sync) are always wrong in the same manner. > > the last git version of intel_reg_dumper gives me: > with i915 loaded: > http://maumae.net/retina/intel_corrupted_drm_debug/ird_i915_loaded > with i915.die=1: > http://maumae.net/retina/intel_corrupted_drm_debug/ird_i915_not_loaded Can you please try the below quick hack. If that doesn't cut it, I need to improve the reg_dumper tool first, the efi firmware sets things up on pipe C, which we currently don't dump. -Daniel diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 0a56b9a..d7462da 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -920,9 +920,9 @@ intel_dp_mode_set(struct drm_encoder *encoder, struct drm_display_mode *mode, /* Split out the IBX/CPU vs CPT settings */ if (is_cpu_edp(intel_dp) && IS_GEN7(dev)) { - if (adjusted_mode->flags & DRM_MODE_FLAG_PHSYNC) + //if (adjusted_mode->flags & DRM_MODE_FLAG_PHSYNC) intel_dp->DP |= DP_SYNC_HS_HIGH; - if (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC) + //if (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC) intel_dp->DP |= DP_SYNC_VS_HIGH; intel_dp->DP |= DP_LINK_TRAIN_OFF_CPT; -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48