From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: dump the device info
Date: Thu, 9 Aug 2012 18:29:56 +0200
Message-ID: <20120809162956.GD5367@phenom.ffwll.local>
References: <1344450604_60059@CP5-2952>
	<1344456111-31467-1-git-send-email-daniel.vetter@ffwll.ch>
	<1344462074_60745@CP5-2952>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com
	[209.85.212.171])
	by gabe.freedesktop.org (Postfix) with ESMTP id 8772CA0ECA
	for <intel-gfx@lists.freedesktop.org>;
	Thu,  9 Aug 2012 09:29:37 -0700 (PDT)
Received: by wibhq4 with SMTP id hq4so378089wib.12
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 09 Aug 2012 09:29:36 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1344462074_60745@CP5-2952>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Aug 08, 2012 at 10:41:14PM +0100, Chris Wilson wrote:
> On Wed,  8 Aug 2012 22:01:51 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > Handy for lazy people like me, or when people forget to add the output
> > of lspci -nn.
> > 
> > v2: Chris Wilson noticed that we have this duplicated already in the
> > i915_capabilites debugfs file. But there \n as separator looks better,
> > which would be a bit verbose in dmesg. Abuse the preprocessor to
> > extract this all.
> > 
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> I like the placement of the cpp magic next to the struct, that should make
> it easier to update both at the same time. I think I'd prefer the struct
> first, magic cpp second. And given the alternatives, I think this is
> the cleanest way to minimise the code duplication.
> 
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Queued for -next, thanks for the review.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48