From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 6/8] drm/i915: add parentheses around PIXCLK_GATE definitions Date: Thu, 9 Aug 2012 18:43:46 +0200 Message-ID: <20120809164346.GF5367@phenom.ffwll.local> References: <1344446134-3704-1-git-send-email-przanoni@gmail.com> <1344446134-3704-7-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 30F8CA0EDE for ; Thu, 9 Aug 2012 09:43:27 -0700 (PDT) Received: by weyr3 with SMTP id r3so458533wey.36 for ; Thu, 09 Aug 2012 09:43:26 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1344446134-3704-7-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Wed, Aug 08, 2012 at 02:15:32PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > By looking at the current way we're using these definitions I don't > think this commit will fix any bug, but programmers from the future > are evil and will certainly find ways to combine macro expansion with > operator precedence to introduce bugs that are hard to find. > > Signed-off-by: Paulo Zanoni I've applied all patches up to and including this one here (with the pbc mispell fixed). I agree with Jani's bikeshed on patch 7, and I think we need to discuss patch 8 some more on irc. I think something similar to the pch pll sharing is required here. Thanks for the patches&review. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48