From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: try harder to find WR PLL clock settings Date: Fri, 10 Aug 2012 18:40:30 +0200 Message-ID: <20120810164030.GD5738@phenom.ffwll.local> References: <1344446134-3704-1-git-send-email-przanoni@gmail.com> <1344603783-4386-1-git-send-email-przanoni@gmail.com> <877gt6khqi.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id B512DA0FB0 for ; Fri, 10 Aug 2012 09:40:09 -0700 (PDT) Received: by wgbdr1 with SMTP id dr1so1251015wgb.12 for ; Fri, 10 Aug 2012 09:40:08 -0700 (PDT) Content-Disposition: inline In-Reply-To: <877gt6khqi.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Fri, Aug 10, 2012 at 04:18:45PM +0300, Jani Nikula wrote: > On Fri, 10 Aug 2012, Paulo Zanoni wrote: > > From: Paulo Zanoni > > > > If we don't find the exact refresh rate, go with the next one. This > > makes some modes work for me. They won't have the best settings, but > > will at least have something. Just returning from this function when > > we don't find the perfect settings does not help us at all. > > > > Version 2: > > - Remove duplicate lines on the clock table. > > - Add back debug message with refresh, p, n2 and r2. > > Reviewed-by: Jani Nikula Queued for -next, thanks for the review. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48