From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: don't grab dev->struct_mutex for userspace forcewak Date: Sat, 11 Aug 2012 22:23:25 +0200 Message-ID: <20120811202325.GF5132@phenom.ffwll.local> References: <1344544438-5654-1-git-send-email-daniel.vetter@ffwll.ch> <1344637338_72217@CP5-2952> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id E2CA89E7D8 for ; Sat, 11 Aug 2012 13:23:05 -0700 (PDT) Received: by weyr3 with SMTP id r3so1839668wey.36 for ; Sat, 11 Aug 2012 13:23:05 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1344637338_72217@CP5-2952> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: Daniel Vetter , Intel Graphics Development , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Fri, Aug 10, 2012 at 11:22:15PM +0100, Chris Wilson wrote: > On Thu, 9 Aug 2012 22:33:58 +0200, Daniel Vetter wrote: > > Since forcewake is now protected by a spinlock, we don't need to grab > > dev->struct_mutex any more. This way we can also get rid of a stale > > comment, noticed by Ben Widawsky while reviewing some locking changes. > > > > Signed-off-by: Daniel Vetter > > Reviewed-by: Chris Wilson > (Although I still wish it were not so) Queued for -next, thanks for the review. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48