From mboxrd@z Thu Jan  1 00:00:00 1970
From: Fengguang Wu <fengguang.wu@intel.com>
Subject: Re: [PATCH V2 2/2] intel_audio_dump: add Haswell audio
	dump support
Date: Wed, 15 Aug 2012 16:00:59 +0800
Message-ID: <20120815080059.GB28901@localhost>
References: <1344329570-17939-1-git-send-email-xingchao.wang@intel.com>
	<1344329570-17939-3-git-send-email-xingchao.wang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
	by gabe.freedesktop.org (Postfix) with ESMTP id 4BC84A0C32
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 15 Aug 2012 01:01:06 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1344329570-17939-3-git-send-email-xingchao.wang@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Wang Xingchao <xingchao.wang@intel.com>
Cc: michael.fu@intel.com, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Xingchao,

Have you tested the patch in haswell as well as in older hardwares?
In general it would be better if you have run this tool for some time
on several hardwares -- that's the best way to smooth out possible bugs.

> +/*Haswell registers*/

Please fix the style to (ditto for lots of other comments)

> +/* Haswell registers */

Thanks,
Fengguang