From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Don't hardcode the number of pipes in the error state dump Date: Thu, 16 Aug 2012 00:40:13 +0200 Message-ID: <20120815224013.GD5533@phenom.ffwll.local> References: <1345055005-23850-1-git-send-email-damien.lespiau@gmail.com> <1345056147_100284@CP5-2952> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by gabe.freedesktop.org (Postfix) with ESMTP id EB0429E848 for ; Wed, 15 Aug 2012 15:39:51 -0700 (PDT) Received: by wibhq4 with SMTP id hq4so75101wib.12 for ; Wed, 15 Aug 2012 15:39:51 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1345056147_100284@CP5-2952> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Aug 15, 2012 at 07:42:15PM +0100, Chris Wilson wrote: > On Wed, 15 Aug 2012 19:23:25 +0100, Damien Lespiau wrote: > > From: Damien Lespiau > > > > New-ish devices have 3 pipes, so let's not just hardcode 2 but use the > > for_each_pipe() macro and make struct intel_display_error_state is big > > enough. > > > > V2: Also add the number of pipes emitted (Chris Wilson) > > > > Signed-off-by: Damien Lespiau > Reviewed-by: Chris Wilson Queued for -next, thanks for the patch. > I guess next on your list will be adding some of the PCH register > states, along with a list of active encoders / connectors etc. I'm not sure that's worth it, at least usually the gt doesn't fall over when we anger the pch ... Simply grabbing a register dump for interesting configurations and comparing them worksforme. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48