From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/5] drm/i915/contexts: fix list corruption Date: Thu, 16 Aug 2012 00:50:55 +0200 Message-ID: <20120815225055.GH5533@phenom.ffwll.local> References: <1344980117-1993-1-git-send-email-ben@bwidawsk.net> <1344980117-1993-3-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by gabe.freedesktop.org (Postfix) with ESMTP id 25D189EB1F for ; Wed, 15 Aug 2012 15:50:34 -0700 (PDT) Received: by wibhq4 with SMTP id hq4so80267wib.12 for ; Wed, 15 Aug 2012 15:50:33 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1344980117-1993-3-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Aug 14, 2012 at 02:35:14PM -0700, Ben Widawsky wrote: > After reset we unconditionally reinitialize lists. If the context switch > hasn't yet completed before the suspend, the default context object will > end up on lists that are going to go away when we resume. > > The patch forces the context switch to be synchronous before suspend > assuring that the active/inactive tracking is correct at the time of > resume. > > References: https://bugs.freedesktop.org/show_bug.cgi?id=52429 > Tested-by: Guang A Yang > Signed-off-by: Ben Widawsky > Reviewed-by: Chris Wilson Picked up for -fixes (with a minor conflict resolved), thanks for the patch. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48