From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: Find bugs in i915 driver
Date: Wed, 22 Aug 2012 10:38:06 +0200
Message-ID: <20120822083514.GA5186@phenom.ffwll.local>
References: <D908B1B9E708C047A32444772B58AE88212DC1@SHSMSX101.ccr.corp.intel.com>
	<1343721467_20698@CP5-2952>
	<D908B1B9E708C047A32444772B58AE8821306D@SHSMSX101.ccr.corp.intel.com>
	<20120731142318.GA3502@kroah.com>
	<20120810114103.GB5738@phenom.ffwll.local>
	<D908B1B9E708C047A32444772B58AE882154DD@SHSMSX101.ccr.corp.intel.com>
	<1344841836.4126.11.camel@mattotaupa>
	<D908B1B9E708C047A32444772B58AE8821565A@SHSMSX101.ccr.corp.intel.com>
	<20120821072037.GB5156@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-bk0-f49.google.com (mail-bk0-f49.google.com
	[209.85.214.49])
	by gabe.freedesktop.org (Postfix) with ESMTP id 06CA99E917
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 22 Aug 2012 01:37:48 -0700 (PDT)
Received: by bkcji2 with SMTP id ji2so194316bkc.36
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 22 Aug 2012 01:37:47 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20120821072037.GB5156@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: "Xu, Anhua" <anhua.xu@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>, "stable@vger.kernel.org" <stable@vger.kernel.org>, Paul Menzel <paulepanter@users.sourceforge.net>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Aug 21, 2012 at 09:20:37AM +0200, Daniel Vetter wrote:
> On Mon, Aug 13, 2012 at 08:07:43AM +0000, Xu, Anhua wrote:
> > Hi, Paul
> > 
> > Thanks for your advice. I update my patch. Please review, for your question, please see my reply below. 
> > 
> > From d11080eda81c0503b5035ea40667b06fe2ee0fb5 Mon Sep 17 00:00:00 2001
> > From: Anhua Xu <anhua.xu@intel.com>
> > Date: Tue, 31 Jul 2012 17:16:50 +0800
> > Subject: [PATCH v3] drm/i915: fix wrong order of parameters in port checking functions
> > 
> > Wrong order of parameters passed-in when calling hdmi/adpa
> > /lvds_pipe_enabled(), 2nd and 3rd parameters are reversed.
> > This bug was indroduced by below commit:
> > 
> > commit 1519b9956eb4b4180fa3f47c73341463cdcfaa37
> > Author: Keith Packard <keithp@keithp.com>
> > Date:   Sat Aug 6 10:35:34 2011 -0700
> > 
> >     drm/i915: Fix PCH port pipe select in CPT disable paths
> > 
> > The reachable tag for this commit is v3.1-rc1-3-g1519b99
> > 
> > Signed-off-by: Anhua Xu <anhua.xu@intel.com>
> > Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>
> 
> I've just remembered that we have a bug report that bisects to the above
> commit:
> 
> https://bugs.freedesktop.org/show_bug.cgi?id=44876

And this does indeeed fix the bug! I've moved the patch to -fixes, with cc
stable added.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48