From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2] drm/i915: Cantiga+ cannot handle a hsync front porch of 0 Date: Wed, 22 Aug 2012 17:39:46 +0200 Message-ID: <20120822153946.GC5186@phenom.ffwll.local> References: <68e45eed497d3fef1ee9756f4648eb97b7fdd4aa.1340222977.git.jani.nikula@intel.com> <1340273999-13342-1-git-send-email-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id 4E169A0A94 for ; Wed, 22 Aug 2012 08:39:24 -0700 (PDT) Received: by wgbdr1 with SMTP id dr1so783101wgb.12 for ; Wed, 22 Aug 2012 08:39:23 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1340273999-13342-1-git-send-email-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Jun 21, 2012 at 01:19:59PM +0300, Jani Nikula wrote: > From: Chris Wilson > > This addresses WaPruneModeWithIncorrectHsyncOffset. > > Bugzilla: http://bugs.freedesktop.org/show_bug.cgi?id=50236 > Signed-off-by: Chris Wilson > Signed-off-by: Jani Nikula Queued for -next (just to close another annoying bugzilla entry), thanks for the patch. -Daniel > > --- > > v2: drop patch 1/2, to be addressed later. > --- > drivers/gpu/drm/i915/intel_display.c | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index 9730162..76516b9 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -3420,6 +3420,13 @@ static bool intel_crtc_mode_fixup(struct drm_crtc *crtc, > if (!(adjusted_mode->private_flags & INTEL_MODE_CRTC_TIMINGS_SET)) > drm_mode_set_crtcinfo(adjusted_mode, 0); > > + /* WaPruneModeWithIncorrectHsyncOffset: Cantiga+ cannot handle modes > + * with a hsync front porch of 0. > + */ > + if ((INTEL_INFO(dev)->gen > 4 || IS_G4X(dev)) && > + adjusted_mode->hsync_start == adjusted_mode->hdisplay) > + return false; > + > return true; > } > > -- > 1.7.4.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48