From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 6/7] drm/i915: Show render P state thresholds in sysfs Date: Thu, 6 Sep 2012 14:48:38 -0700 Message-ID: <20120906144838.6d378527@jbarnes-desktop> References: <1346964850-2228-1-git-send-email-ben@bwidawsk.net> <1346964850-2228-7-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy12-pub.bluehost.com (oproxy12-pub.bluehost.com [50.87.16.10]) by gabe.freedesktop.org (Postfix) with SMTP id C5979A0C86 for ; Thu, 6 Sep 2012 14:48:36 -0700 (PDT) In-Reply-To: <1346964850-2228-7-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org, Jacob Pan List-Id: intel-gfx@lists.freedesktop.org On Thu, 6 Sep 2012 13:54:09 -0700 Ben Widawsky wrote: > This is useful for userspace utilities which wish to use the previous > interface, specifically for micromanaging the increase/decrease steps by > setting min == max. > > CC: Jacob Pan > CC: Jesse Barnes > Signed-off-by: Ben Widawsky > --- > drivers/gpu/drm/i915/i915_sysfs.c | 36 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_sysfs.c b/drivers/gpu/drm/i915/i915_sysfs.c > index 5a5e610..e3a31ae 100644 > --- a/drivers/gpu/drm/i915/i915_sysfs.c > +++ b/drivers/gpu/drm/i915/i915_sysfs.c > @@ -333,10 +333,46 @@ static DEVICE_ATTR(gt_cur_freq_mhz, S_IRUGO, gt_cur_freq_mhz_show, NULL); > static DEVICE_ATTR(gt_max_freq_mhz, S_IRUGO | S_IWUSR, gt_max_freq_mhz_show, gt_max_freq_mhz_store); > static DEVICE_ATTR(gt_min_freq_mhz, S_IRUGO | S_IWUSR, gt_min_freq_mhz_show, gt_min_freq_mhz_store); > > + > +static ssize_t gt_rp_mhz_show(struct device *kdev, struct device_attribute *attr, char *buf); > +static DEVICE_ATTR(gt_RP0_freq_mhz, S_IRUGO, gt_rp_mhz_show, NULL); > +static DEVICE_ATTR(gt_RP1_freq_mhz, S_IRUGO, gt_rp_mhz_show, NULL); > +static DEVICE_ATTR(gt_RPn_freq_mhz, S_IRUGO, gt_rp_mhz_show, NULL); > + > +/* For now we have a static number of RP states */ > +static ssize_t gt_rp_mhz_show(struct device *kdev, struct device_attribute *attr, char *buf) > +{ > + struct drm_minor *minor = container_of(kdev, struct drm_minor, kdev); > + struct drm_device *dev = minor->dev; > + struct drm_i915_private *dev_priv = dev->dev_private; > + u32 val, rp_state_cap; > + ssize_t ret; > + > + ret = mutex_lock_interruptible(&dev->struct_mutex); > + if (ret) > + return ret; > + rp_state_cap = I915_READ(GEN6_RP_STATE_CAP); > + mutex_unlock(&dev->struct_mutex); > + > + if (attr == &dev_attr_gt_RP0_freq_mhz) { > + val = ((rp_state_cap & 0x0000ff) >> 0) * GT_FREQUENCY_MULTIPLIER; > + } else if (attr == &dev_attr_gt_RP1_freq_mhz) { > + val = ((rp_state_cap & 0x00ff00) >> 8) * GT_FREQUENCY_MULTIPLIER; > + } else if (attr == &dev_attr_gt_RPn_freq_mhz) { > + val = ((rp_state_cap & 0xff0000) >> 16) * GT_FREQUENCY_MULTIPLIER; > + } else { > + BUG(); > + } > + return snprintf(buf, PAGE_SIZE, "%d", val); > +} > + > static const struct attribute *gen6_attrs[] = { > &dev_attr_gt_cur_freq_mhz.attr, > &dev_attr_gt_max_freq_mhz.attr, > &dev_attr_gt_min_freq_mhz.attr, > + &dev_attr_gt_RP0_freq_mhz.attr, > + &dev_attr_gt_RP1_freq_mhz.attr, > + &dev_attr_gt_RPn_freq_mhz.attr, > NULL, > }; > If you add documentation: Reviewed-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center