From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 04/24] drm/i915: Pin backing pages for pread Date: Thu, 6 Sep 2012 17:10:03 -0700 Message-ID: <20120906171003.79cb2eda@bwidawsk.net> References: <1346788996-19080-1-git-send-email-chris@chris-wilson.co.uk> <1346788996-19080-5-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from shiva.chad-versace.us (209-20-75-48.static.cloud-ips.com [209.20.75.48]) by gabe.freedesktop.org (Postfix) with ESMTP id B1C899E91B for ; Thu, 6 Sep 2012 17:10:12 -0700 (PDT) In-Reply-To: <1346788996-19080-5-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 4 Sep 2012 21:02:56 +0100 Chris Wilson wrote: > By using the recently introduced pinning of pages, we can safely drop > the mutex in the knowledge that the pages are not going to disappear > beneath us, and so we can simplify the code for iterating over the pages. > > Signed-off-by: Chris Wilson If you fix patch3 to explain, it explain here too. Write is always scarier for me anyway. With fixed patch 3, it's Reviewed-by: Ben Widawsky -- Ben Widawsky, Intel Open Source Technology Center