From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH] intel: properly test for HAS_LLC
Date: Fri, 7 Sep 2012 23:22:19 -0700
Message-ID: <20120907232219.3ff27f5f@bwidawsk.net>
References: <1346404733-25372-1-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from shiva.chad-versace.us (209-20-75-48.static.cloud-ips.com
	[209.20.75.48])
	by gabe.freedesktop.org (Postfix) with ESMTP id 68A519E861
	for <intel-gfx@lists.freedesktop.org>;
	Fri,  7 Sep 2012 23:22:32 -0700 (PDT)
In-Reply-To: <1346404733-25372-1-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, 31 Aug 2012 11:18:53 +0200
Daniel Vetter <daniel.vetter@ffwll.ch> wrote:

> If the kernel supports the test, we need to check the param.
> Copy&pasta from the above checks that only look at the return value.
> Interesting how much one can get such a simple interface wrong.
> 
> Issue created in
> 
> commit 151cdcfe685ee280a4344dfc40e6087d74a5590f
> Author: Eugeni Dodonov <eugeni.dodonov@intel.com>
> Date:   Tue Jan 17 15:20:19 2012 -0200
> 
>     intel: query for LLC support
> 
> Patch even claims to have fixed this in v2, but is actually unchanged
> from v1.
> 
> Reported-by: Xiang, Haihao <haihao.xiang@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Ben Widawsky <ben@bwidawsk.net>

-- 
Ben Widawsky, Intel Open Source Technology Center