From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: rip out early dp port write for
	gm45/ilk
Date: Thu, 13 Sep 2012 13:39:17 +0200
Message-ID: <20120913113917.GA5693@phenom.ffwll.local>
References: <1347485049-19003-1-git-send-email-daniel.vetter@ffwll.ch>
	<6c3329$61f23h@orsmga002.jf.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-bk0-f49.google.com (mail-bk0-f49.google.com
	[209.85.214.49])
	by gabe.freedesktop.org (Postfix) with ESMTP id E4CE0A0DFB
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 13 Sep 2012 04:38:51 -0700 (PDT)
Received: by bkcji2 with SMTP id ji2so463089bkc.36
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 13 Sep 2012 04:38:51 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <6c3329$61f23h@orsmga002.jf.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Sep 13, 2012 at 11:10:14AM +0100, Chris Wilson wrote:
> On Wed, 12 Sep 2012 23:24:09 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > It's bogus.
> > 
> > If I've followed the history of this piece of code correctly, i.e. the
> > initial register write with the following vblank wait, this goes all
> > the way back to the original enabling of DP support in
> > 
> > commit a4fc5ed69817c73e32571ad7837bb707f9890009
> > Author: Keith Packard <keithp@keithp.com>
> > Date:   Tue Apr 7 16:16:42 2009 -0700
> > 
> >     drm/i915: Add Display Port support
> > 
> > Unfortunately it seems to be nothing more than glorified duct-tape and
> > sometimes actively harmful. Adam Jackson noticed this for CPT
> > platforms with
> > 
> > commit e85194641bec56179dcf5e1704ce5c6bf30340c6
> > Author: Adam Jackson <ajax@redhat.com>
> > Date:   Thu Jul 21 17:48:38 2011 -0400
> > 
> >     drm/i915/dp: Don't turn CPT DP ports on too early
> > 
> > Unfortunately this kept the code around for ilk and gm45.
> > 
> > The specific failure case I'm seeing here is that after a dpms off/on
> > cycle we have the bits from the last link training (hopefully
> > successful link training) set in intel_dp->DP. This is requiered so
> > that complete_link_train can enable the port with the right tuning
> > values.
> > 
> > Unfortunately writing these again to the disabled port at dpms on time
> > kills the port somehow until it's disabled - dp link training fails in
> > an endless loop without this patch on my mobile ilk and gm45.
> > 
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> Works for me, only time will time if I no longer get the occasional
> failure in link training, but it definitely fixes the issue with dpms
> off.
> 
> Tested-by: Chris Wilson <chris@chris-wilson.co.uk>
> Probably https://bugs.freedesktop.org/show_bug.cgi?id=51493

Queued for -next, thanks for testing - imo this patch is too risky for
-fixes at this point in the release cycle.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch