From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH v2 5/9] drm/i915: Disable CRT hotplug
 detection for valleyview
Date: Thu, 27 Sep 2012 08:20:15 -0700
Message-ID: <20120927082015.7c977aba@jbarnes-desktop>
References: <1348753389-30736-1-git-send-email-vijay.a.purushothaman@intel.com>
	<1348753389-30736-6-git-send-email-vijay.a.purushothaman@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from oproxy8-pub.bluehost.com (oproxy8-pub.bluehost.com
	[69.89.22.20])
	by gabe.freedesktop.org (Postfix) with SMTP id 340099E93F
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 27 Sep 2012 08:20:00 -0700 (PDT)
In-Reply-To: <1348753389-30736-6-git-send-email-vijay.a.purushothaman@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Vijay Purushothaman <vijay.a.purushothaman@intel.com>
Cc: Intel Graphics <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Thu, 27 Sep 2012 19:13:05 +0530
Vijay Purushothaman <vijay.a.purushothaman@intel.com> wrote:

> Temporary work around to avoid spurious crt hotplug interrupts.
> 
> Signed-off-by: Vijay Purushothaman <vijay.a.purushothaman@intel.com>
> Signed-off-by: Gajanan Bhat <gajanan.bhat@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_crt.c |    7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/intel_crt.c
> index c42b980..5f30364 100644
> --- a/drivers/gpu/drm/i915/intel_crt.c
> +++ b/drivers/gpu/drm/i915/intel_crt.c
> @@ -308,6 +308,13 @@ static bool valleyview_crt_detect_hotplug(struct drm_connector *connector)
>  	bool ret;
>  	u32 save_adpa;
>  
> +	/*
> +	 * Disable crt detect hotplug for VLV X0. Spurious hot plug
> +	 * detect calls crashses the X0 system
> +	 */
> +	if (IS_VALLEYVIEW(dev))
> +		return false;
> +
>  	save_adpa = adpa = I915_READ(ADPA);
>  	DRM_DEBUG_KMS("trigger hotplug detect cycle: adpa=0x%x\n", adpa);
>  

Not sure about this one; your platform seems to be less stable than
mine when it comes to both VGA port handling and legacy VGA I/O...  But
I have no problem with it either, I just know it works ok on at least
some of the SDVs, probably depending on board rework and firmware
status.

Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>

-- 
Jesse Barnes, Intel Open Source Technology Center