From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Try harder to complete DP
 training pattern 1
Date: Wed, 3 Oct 2012 16:00:07 +0200
Message-ID: <20121003140007.GF5329@phenom.ffwll.local>
References: <1348674510-19494-1-git-send-email-chris@chris-wilson.co.uk>
	<CAPX-8+_X7xuWze=xL4c8vPcpJ1M+JTk2fXFcEmR=pRvOkmQ8cA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-we0-f177.google.com (mail-we0-f177.google.com
	[74.125.82.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id CD48E9E997
	for <intel-gfx@lists.freedesktop.org>;
	Wed,  3 Oct 2012 06:59:15 -0700 (PDT)
Received: by weyu50 with SMTP id u50so4430587wey.36
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 03 Oct 2012 06:59:14 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CAPX-8+_X7xuWze=xL4c8vPcpJ1M+JTk2fXFcEmR=pRvOkmQ8cA@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: "Lespiau, Damien" <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Oct 03, 2012 at 02:50:19PM +0100, Lespiau, Damien wrote:
> On Wed, Sep 26, 2012 at 4:48 PM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > In commit cdb0e95bf571dccc1f75fef9bdad21b167ef0b37
> > Author: Keith Packard <keithp@keithp.com>
> > Date:   Tue Nov 1 20:00:06 2011 -0700
> >
> >     drm/i915: Try harder during dp pattern 1 link training
> >
> > extra passes were made to retry the same voltage and then retry a full
> > clock reset. However, as coverity pointed out, we never tried the full
> > clock reset as we broke out of the loop early.
> 
> Took me a while to wrap my head around this one, no wonder only
> Coverity pointed out. I managed to convince myself the fix is correct
> though.
> 
> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>

Picked up for -fixes, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch