From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH v2 1/2] drm/i915: EBUSY status handling
 added to i915_gem_fault().
Date: Wed, 3 Oct 2012 16:30:52 +0200
Message-ID: <20121003143052.GG5329@phenom.ffwll.local>
References: <1349270822-29740-1-git-send-email-mika.kuoppala@intel.com>
	<1349273727-14362-1-git-send-email-mika.kuoppala@intel.com>
	<051c15$4gt4qo@AZSMGA002.ch.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-bk0-f49.google.com (mail-bk0-f49.google.com
	[209.85.214.49])
	by gabe.freedesktop.org (Postfix) with ESMTP id 39A6E9E831
	for <intel-gfx@lists.freedesktop.org>;
	Wed,  3 Oct 2012 07:30:01 -0700 (PDT)
Received: by bkwj4 with SMTP id j4so5801337bkw.36
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 03 Oct 2012 07:30:00 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <051c15$4gt4qo@AZSMGA002.ch.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, mika.kuoppala@intel.com
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Oct 03, 2012 at 03:27:36PM +0100, Chris Wilson wrote:
> On Wed,  3 Oct 2012 17:15:26 +0300, mika.kuoppala@intel.com wrote:
> > From: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
> > 
> > Subsequent threads returning EBUSY from vm_insert_pfn() was not handled
> > correctly. As a result concurrent access from new threads to
> > mmapped data caused SIGBUS.
> > 
> > Tested-by: Mika Kuoppala <mika.kuoppala@intel.com>
> > Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
> 
> Fixes? Reported-by?
> 
> I would order the case slightly different so that the comment block
> comes after EIO.
> 
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

I've added the fixes note and applied both patches to -fixes. Thanks for
the patch & review.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch