From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 08/10] drm/i915: don't rely on previous values set on DDI_BUF_CTL Date: Wed, 10 Oct 2012 20:18:19 +0200 Message-ID: <20121010181819.GG5533@phenom.ffwll.local> References: <1349211142-4802-1-git-send-email-przanoni@gmail.com> <1349449561-3599-1-git-send-email-przanoni@gmail.com> <1349449561-3599-9-git-send-email-przanoni@gmail.com> <20121010145607.GF5533@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id D3E029F78F for ; Wed, 10 Oct 2012 11:17:22 -0700 (PDT) Received: by mail-wg0-f43.google.com with SMTP id dq11so586426wgb.12 for ; Wed, 10 Oct 2012 11:17:22 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20121010145607.GF5533@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: "Lespiau, Damien" Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Wed, Oct 10, 2012 at 04:56:07PM +0200, Daniel Vetter wrote: > On Wed, Oct 10, 2012 at 03:27:59PM +0100, Lespiau, Damien wrote: > > On Fri, Oct 5, 2012 at 4:05 PM, Paulo Zanoni wrote: > > > From: Paulo Zanoni > > > > > > Just set the only bit we need, everything else is either ignored on > > > HDMI or should be set to zero. > > > > > > Signed-off-by: Paulo Zanoni > > > > Is the assumption that intel_enable_ddi() will only ever be used by > > the HDMI encore likely to hold true for ever? looks like a general > > function that could be used by others to me. Also intel_disable_ddi() > > read the register back, so it'd be unfair to only touch > > intel_enable_ddi() if you want to do that. > > > > I'd just stay on the safe side and retain the programming here. > > I'd prefer to go safe and do our own programming ;-) Imo it's better to > fully program a register than to rely on random garbage left behind by the > bios - usually that allows us to bring up hw a bit quicker, but in the end > results in some nasty bug reports once hw starts shipping. For the disable > side things are usually not that important, since we need to assume that > our own code (or our own hw state readout) set things up correctly. > > Wrt the general usefullness of, I guess the dp patches will changed that. > I'll just merge this one here. Ok, I've merged this series up to this patch. The last two patches are pending an r-b from a volunteer ;-) Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch