From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: don't implement
 WaDisableEarlyCull for Haswell
Date: Wed, 10 Oct 2012 23:46:43 +0200
Message-ID: <20121010214642.GA10810@phenom.ffwll.local>
References: <1349903399-4417-1-git-send-email-przanoni@gmail.com>
	<CAPX-8+9m4yUiN1mPNRDqNRysu1BPcvkm5oxW4=7TeAZDZCGdGg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-we0-f177.google.com (mail-we0-f177.google.com
	[74.125.82.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id 330999F57D
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 10 Oct 2012 14:45:52 -0700 (PDT)
Received: by mail-we0-f177.google.com with SMTP id u50so633917wey.36
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 10 Oct 2012 14:45:51 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CAPX-8+9m4yUiN1mPNRDqNRysu1BPcvkm5oxW4=7TeAZDZCGdGg@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: "Lespiau, Damien" <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni <paulo.r.zanoni@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Oct 10, 2012 at 10:42:52PM +0100, Lespiau, Damien wrote:
> On Wed, Oct 10, 2012 at 10:09 PM, Paulo Zanoni <przanoni@gmail.com> wrote:
> > From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >
> > Introduced in commit 87f8020ec9e3069597746040a4e8655189bc0c1a:
> >   drm/i915: implement WaDisableEarlyCull for VLV and IVB
> >
> > Notice that the original patch sent to the mailing list did not
> > include the Haswell chunk, it was added later.
> >
> > The bit set by the commit does not exist on Haswell machines (at least
> > that's what the documentation says). Also, the commit gives me a GPU
> > hang every time we're loading the driver. So let's revert the Haswell
> > chunk, making the patch do only what its title actually says.
> >
> > Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> 
> Indeed the bit definition has disappeared in the documentation, but
> the wa is listed in the wa database. A hang is very handy to decide
> who is right :)
> 
> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch