From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 02/24] drm/i915: Pin backing pages whilst exporting through a dmabuf vmap Date: Thu, 11 Oct 2012 11:30:47 -0700 Message-ID: <20121011113047.7e9ec98a@jbarnes-desktop> References: <1346788996-19080-1-git-send-email-chris@chris-wilson.co.uk> <1346788996-19080-3-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy9.bluehost.com (oproxy9.bluehost.com [69.89.24.6]) by gabe.freedesktop.org (Postfix) with SMTP id 914359E782 for ; Thu, 11 Oct 2012 11:30:12 -0700 (PDT) In-Reply-To: <1346788996-19080-3-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 4 Sep 2012 21:02:54 +0100 Chris Wilson wrote: > We need to refcount our pages in order to prevent reaping them at > inopportune times, such as when they currently vmapped or exported to > another driver. However, we also wish to keep the lazy deallocation of > our pages so we need to take a pin/unpinned approach rather than a > simple refcount. > > Signed-off-by: Chris Wilson > --- Why do we need the pages pinned if the object is vmapped? Shouldn't we only pin if a vmapped object is currently being used by the GPU or mapped through the GTT? Or is that what you meant? Assuming that's correct: Reviewed-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center