From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: flush system agent TLBs on SNB so we can WC map the PTEs Date: Fri, 12 Oct 2012 10:18:09 +0200 Message-ID: <20121012081809.GA5155@phenom.ffwll.local> References: <20121011103237.21e6637c@jbarnes-desktop> <20121011165451.01980d55@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by gabe.freedesktop.org (Postfix) with ESMTP id 69A53A0DC9 for ; Fri, 12 Oct 2012 01:20:14 -0700 (PDT) Received: by mail-wi0-f171.google.com with SMTP id hj13so32305wib.12 for ; Fri, 12 Oct 2012 01:20:13 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Dave Airlie Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Oct 12, 2012 at 03:54:50AM -0400, Dave Airlie wrote: > On Thu, Oct 11, 2012 at 7:54 PM, Jesse Barnes wrote: > > On Thu, 11 Oct 2012 20:29:47 -0300 > > Paulo Zanoni wrote: > > > >> Hi > >> > >> 2012/10/11 Jesse Barnes : > >> > I've only lightly tested this so far, but the corruption seems to be > >> > gone if I write the GFX_FLSH_CNTL reg after binding an object. This > >> > register should control the TLB for the system agent, which is what CPU > >> > mapped objects will go through. > >> > > >> > Signed-off-by: Jesse Barnes > >> > >> I'm not sure if this is the patch you asked me to test on IRC, but, > >> well this is the patch I tested :) > >> > >> I tested it on HSW on top of dinq + some other patches. Booted the > >> machine, ran mostly xfterm4 under Xfce, but I also ran firefox, > >> gnome-shell and restarted X a few times. No GPU hangs so far. I'm > >> testing this for about 3-4 hours. > >> > >> I do have to say that I could not find this register on the HSW > >> documentation, but I also did no see any "Unclaimed write" messages > >> containing the 101008 address... I'm a little confused. > >> > >> And the interesting thing: intel_gpu_tools is useless now. I keep > >> getting "Couldn't map MMIO region: Resource temporarily unavailable". > >> Do you see this too? > > > > No I haven't seen that, I ran some tests today with the tip of the tree > > too... Dunno why the resource files would return EBUSY? Maybe because > > a driver is bound? > > More likely because of some WB/WC/UC collision. We don't like aliases. Yep, you need to upgrade, latest i-g-t should handle the wc/uc split correctly. The important testcase is gem_gtt_cpu_tlb, if that one works this patch is good. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch