From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: fix non-DP-D eDP backlight cleanup and module reload Date: Fri, 12 Oct 2012 10:25:38 +0200 Message-ID: <20121012082538.GC5155@phenom.ffwll.local> References: <1350027185-24922-1-git-send-email-jani.nikula@intel.com> <87a9vs2ksb.fsf@rosetta.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by gabe.freedesktop.org (Postfix) with ESMTP id 9E7B9A0DB7 for ; Fri, 12 Oct 2012 01:24:38 -0700 (PDT) Received: by mail-wi0-f171.google.com with SMTP id hj13so35514wib.12 for ; Fri, 12 Oct 2012 01:24:38 -0700 (PDT) Content-Disposition: inline In-Reply-To: <87a9vs2ksb.fsf@rosetta.fi.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Mika Kuoppala Cc: Jani Nikula , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Oct 12, 2012 at 10:48:20AM +0300, Mika Kuoppala wrote: > On Fri, 12 Oct 2012 10:33:05 +0300, Jani Nikula wrote: > > Backlight is initialized for eDP, but cleaned up only for eDP on DP-D > > port. This leaves behind a dangling backlight interface on module unload on > > machines that have eDP connected to something other than DP-D, and breaks > > the backlight interface for subsequent module reloads. Fix the cleanup, and > > thus module reload on affected machines. > > > > Reported-by: Imre Deak > > Signed-off-by: Jani Nikula > > Reviewed-by: Mika Kuoppala Picked up for -fixes, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch