From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH 3/3] drm/i915: don't rewrite the GTT on
 resume
Date: Mon, 15 Oct 2012 08:49:33 -0700
Message-ID: <20121015084933.577dd886@jbarnes-t420>
References: <1350267038-3599-1-git-send-email-jbarnes@virtuousgeek.org>
	<1350267038-3599-3-git-send-email-jbarnes@virtuousgeek.org>
	<b94cdc$6v3soq@fmsmga001.fm.intel.com>
	<453bf0$631iug@azsmga001.ch.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from oproxy11-pub.bluehost.com (oproxy11-pub.bluehost.com
	[173.254.64.10])
	by gabe.freedesktop.org (Postfix) with SMTP id 814319F5C2
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 15 Oct 2012 08:49:38 -0700 (PDT)
In-Reply-To: <453bf0$631iug@azsmga001.ch.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Mon, 15 Oct 2012 10:42:03 +0100
Chris Wilson <chris@chris-wilson.co.uk> wrote:

> On Mon, 15 Oct 2012 09:37:00 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > On Sun, 14 Oct 2012 19:10:38 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > > The BIOS shouldn't be touching this memory across suspend/resume, so
> > > just leave it alone.  This saves us ~50ms on resume on my T420.
> > > 
> > > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> > > ---
> > >  drivers/gpu/drm/i915/i915_drv.c |    7 ++++++-
> > >  1 file changed, 6 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> > > index 824e3c8..95e2b8b 100644
> > > --- a/drivers/gpu/drm/i915/i915_drv.c
> > > +++ b/drivers/gpu/drm/i915/i915_drv.c
> > > @@ -119,6 +119,10 @@ module_param_named(i915_enable_ppgtt, i915_enable_ppgtt, int, 0600);
> > >  MODULE_PARM_DESC(i915_enable_ppgtt,
> > >  		"Enable PPGTT (default: true)");
> > >  
> > > +int i915_needs_gtt_restore __read_mostly = 0;
> > > +module_param_named(gtt_restore, i915_needs_gtt_restore, int, 0600);
> > > +MODULE_PARM_DESC(gtt_restore, "Rewrite GTT on resume (default: false)");
> > 
> > Wrong way around. This code exists purely because KMS resume was broken
> > on a number of machines without reinitialising the GTT, ergo this is a
> > regression.
> 
> Looking into the history, at the time we wrote the GTT reinit, I believe
> we did not have a GFX_FLUSH_CNTL in the resume path. Now we do, so I'd
> be more inclined to believe that we have fixed a bug in the meantime. If
> so, we only need to be extra careful for gen2.

Yeah good point, do we have victims who can check this for us?

Jesse