From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] DRM/i915: Restore sdvo_flags after dtd->mode->dtd Roundrtrip. Date: Tue, 16 Oct 2012 09:48:04 +0200 Message-ID: <20121016074804.GI5753@phenom.ffwll.local> References: <1350131371-1268-1-git-send-email-eich@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 462779E7A7 for ; Tue, 16 Oct 2012 00:47:04 -0700 (PDT) Received: by mail-we0-f177.google.com with SMTP id u50so3726971wey.36 for ; Tue, 16 Oct 2012 00:47:03 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1350131371-1268-1-git-send-email-eich@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Egbert Eich Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Sat, Oct 13, 2012 at 02:29:31PM +0200, Egbert Eich wrote: > For TV and LVDS encoders intel_sdvo_set_input_timings_for_mode() > is called to pass a mode to the sdvo chip and retrieve a dtd > containing information needed to calculate the adjusted_mode which > is done by intel_sdvo_get_dtd_from_mode(). > To set this adjusted_mode as input mode for the sdvo chip, a dtd is > recalculated using intel_sdvo_get_mode_from_dtd(). During this round > trip the sdvo_flags contained in the dtd obtained from the hardware > are lost. > Since these flags cannot be ignored in all cases this patch preserves > and restores them. > > This regression has been introduced in > > commit 6651819b4b4fc3caa6964c5d825eb4bb996f3905 > Author: Daniel Vetter > Date: Sun Apr 1 19:16:18 2012 +0200 > > drm/i915: handle input/output sdvo timings separately in mode_set > > Signed-off-by: Egbert Eich Long term we need to decently improve our adjusted_mode handling and stop shoveling random state into random structures. Short-term this looks good enough. Thanks for the patch, applied. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch