From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/2] drm/i915: Allow DRM_ROOT_ONLY|DRM_MASTER to submit privileged batchbuffers Date: Wed, 17 Oct 2012 21:09:40 +0200 Message-ID: <20121017190940.GN5753@phenom.ffwll.local> References: <1350472195-8051-1-git-send-email-chris@chris-wilson.co.uk> <20121017093121.591e3a63@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by gabe.freedesktop.org (Postfix) with ESMTP id 5FC099E709 for ; Wed, 17 Oct 2012 12:08:40 -0700 (PDT) Received: by mail-wi0-f171.google.com with SMTP id hj13so837463wib.12 for ; Wed, 17 Oct 2012 12:08:39 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20121017093121.591e3a63@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Oct 17, 2012 at 09:31:21AM -0700, Jesse Barnes wrote: > On Wed, 17 Oct 2012 12:09:54 +0100 > Chris Wilson wrote: > > > With the introduction of per-process GTT space, the hardware designers > > thought it wise to also limit the ability to write to MMIO space to only > > a "secure" batch buffer. The ability to rewrite registers is the only > > way to program the hardware to perform certain operations like scanline > > waits (required for tear-free windowed updates). So we either have a > > choice of adding an interface to perform those synchronized updates > > inside the kernel, or we permit certain processes the ability to write > > to the "safe" registers from within its command stream. This patch > > exposes the ability to submit a SECURE batch buffer to > > DRM_ROOT_ONLY|DRM_MASTER processes. > > > > Signed-off-by: Chris Wilson > Yeah looks good. > > Reviewed-by: Jesse Barnes Merged, and upgraded Jesse's r-b to the full patch with the hsw changes - he wasn't on irc to deny it ;-). Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch