Re: [PATCH 00/10] drm/i915: LVDS/eDP panel, EDID and fixed mode refactoring

Daniel Vetter
2012-10-22T17:36:37Z

On Fri, Oct 19, 2012 at 06:58:56PM +0100, Chris Wilson wrote:
> On Fri, 19 Oct 2012 14:51:42 +0300, Jani Nikula <jani.nikula@intel.com> wrote:
> > Hi all, this is some LVDS/eDP panel refactoring and cleanup based on
> > Chris Wilson's earlier work and ideas last year [1]. I left out eDP lid
> > notifier based on Jesse's comments [2]; more of Jesse's old review is at
> > [3].
> >
> > The main high level difference to Chris' patches is that intel_panel and
> > the cached EDID are placed in intel_connector rather than anywhere
> > else. This is because Daniel hinted that we might want to do some more
> > generic EDID caching (indeed, why keep reading the EDID if the display
> > has not been unplugged?). With the EDID and intel_panel in
> > intel_connector, we can add functions to query EDID and modes with
> > transparent caching and fallback to fixed mode when EDID is not
> > available.
>
> Patches look really good, I haven't checked yet to see if there is
> anything missing, but I already like the improvement to the code....
>
> So for the series,
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Slurped in the entire series, thanks a lot for the patches and review.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch