From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2] flip_test: add wf-vblank test for expired sequence Date: Tue, 23 Oct 2012 12:46:14 +0200 Message-ID: <20121023104614.GL24005@phenom.ffwll.local> References: <1350927609-14649-5-git-send-email-imre.deak@intel.com> <1350983272-26906-1-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id DA1309E74C for ; Tue, 23 Oct 2012 03:45:12 -0700 (PDT) Received: by mail-wg0-f43.google.com with SMTP id dq11so2428546wgb.12 for ; Tue, 23 Oct 2012 03:45:11 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1350983272-26906-1-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Imre Deak Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Oct 23, 2012 at 12:07:52PM +0300, Imre Deak wrote: > Signed-off-by: Imre Deak > --- > tests/flip_test.c | 58 ++++++++++++++++++++++++++++++++++++++++++++--------- > 1 file changed, 48 insertions(+), 10 deletions(-) > > In v2: > - Wait for the seq that just completed (current_seq) not last_seq - 1. > - Do an equality check for ts and seq instead of >=. The previous issue > didn't let us do this before. > - Simplify the condition when we do an "expired sequence" check by only > using the last flip event as a reference. Patch style comment: I prefer the changelog above the --- so that it's included in the commit message. Safe obviously when the new patch has abosulutely nothing to do with previous versions. Patch applied, thanks. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch