From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915/dp: actually nack test request
Date: Tue, 23 Oct 2012 16:41:05 +0200
Message-ID: <20121023144105.GP24005@phenom.ffwll.local>
References: <1350760385-16634-1-git-send-email-daniel.vetter@ffwll.ch>
	<6c3329$6sard9@orsmga002.jf.intel.com>
	<20121023072535.1e1e62fe@jbarnes-desktop>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com
	[209.85.212.171])
	by gabe.freedesktop.org (Postfix) with ESMTP id 9FBE69F5A9
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 23 Oct 2012 07:40:03 -0700 (PDT)
Received: by mail-wi0-f171.google.com with SMTP id hj13so2812775wib.12
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 23 Oct 2012 07:40:02 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20121023072535.1e1e62fe@jbarnes-desktop>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Oct 23, 2012 at 07:25:35AM -0700, Jesse Barnes wrote:
> On Tue, 23 Oct 2012 10:53:07 +0100
> Chris Wilson <chris@chris-wilson.co.uk> wrote:
> 
> > On Sat, 20 Oct 2012 21:13:05 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > > ... like the comment says. No idea whether this has any effect, but
> > > I guess it's better to not lie to the display by acking a test request
> > > and never following through with it.
> > > 
> > > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > 
> > Ha, if I've learnt anything by now making the code consistent with the
> > comments inside intel_dp.c only leads to pain...
> > 
> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> > 
> > But really this needs an ack by Jesse:
> > 
> > commit a60f0e38d72a5e24085d6e7e27a4cadc20ae268a
> > Author: Jesse Barnes <jbarnes@virtuousgeek.org>
> > Date:   Thu Oct 20 15:09:17 2011 -0700
> > 
> >     drm/i915: add DP test request handling
> >     
> >     DPCD 1.1+ adds some automated test infrastructure support.  Add support
> >     for reading the IRQ source and jumping to a test handling routine if
> >     needed.  Subsequent patches will handle particular tests; this patch
> >     just ACKs any requested tests by default.
> > -Chris
> > 
> 
> I don't think it matters; the only thing that should be looking at this
> is the DP test equipment.  I haven't seen any sinks generate test
> requests yet (but then I don't have many...).
> 
> So 'meh' on this patch from me.

Applied, thanks for the review.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch