From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 10/10] drm/i915: Kill off actually requiring
 AGP
Date: Fri, 26 Oct 2012 00:47:31 +0200
Message-ID: <20121025224731.GH5691@phenom.ffwll.local>
References: <1350956055-3224-1-git-send-email-ben@bwidawsk.net>
	<1350956055-3224-11-git-send-email-ben@bwidawsk.net>
	<20121025140909.56b7116b@jbarnes-desktop>
	<20121025151502.5a97e0ac@bwidawsk.net>
	<20121025153908.4689881e@jbarnes-desktop>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41])
	by gabe.freedesktop.org (Postfix) with ESMTP id E09A2A0B19
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 25 Oct 2012 15:46:28 -0700 (PDT)
Received: by mail-wg0-f41.google.com with SMTP id ds1so116763wgb.0
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 25 Oct 2012 15:46:28 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20121025153908.4689881e@jbarnes-desktop>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Ben Widawsky <ben@bwidawsk.net>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Oct 25, 2012 at 03:39:08PM -0700, Jesse Barnes wrote:
> > > It would be cool to actually remove the dep for pre-gen6.  I don't
> > > think we need this patch in either case.
> > > 
> > 
> > Your linker is going to complain without it, unless I don't follow your
> > meaning.
> 
> I mean unless we split the driver into gen6+ and pre-gen6 (with a
> config option or otherwise), we can't really kill the dependency unless
> we actually pull the rest of the AGP stuff we need into i915.  I'd kind
> of like to do the latter, but the non-KMS configs would break.

Also, some kms config actually break because we've managed to ship
userspace that uses kms, but in parts also still uses the legacy drmMap
api. Which in our case means we need to have a working (but fake) agp
driver around. This entire thing is one giant mess, but I think with the
gen6+ stuff moved it's about as good as it will get. And I don't mind the
old crap too much, we have an entire dungeon full of them in i915_dma.c,
too ;-)
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch