From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Flush using only the correct base address register Date: Tue, 30 Oct 2012 20:37:24 +0100 Message-ID: <20121030193724.GB5755@phenom.ffwll.local> References: <1351524289-21465-1-git-send-email-damien.lespiau@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 8BD709E730 for ; Tue, 30 Oct 2012 12:36:22 -0700 (PDT) Received: by mail-ee0-f49.google.com with SMTP id c1so370701eek.36 for ; Tue, 30 Oct 2012 12:36:18 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Oct 30, 2012 at 09:01:57AM -0200, Paulo Zanoni wrote: > Hi > > 2012/10/29 Damien Lespiau : > > From: Damien Lespiau > > > > We were writing DSP_ADDR and DSP_SURF unconditionally. This did not > > trigger an unclaimed write before HSW as the address of DSP_ADDR has > > been repurposed as DSP_LINOFF. > > > > On HSW, though, DSP_LINOFF has been removed and then writting to it > > triggers an unclaimed write. > > > > This patch writes to DSP_ADDR or DSP_SURF to flush the display plane > > configuration depending on the gen we're running on. > > > > Signed-off-by: Damien Lespiau > > Looks correct. > > Reviewed-by: Paulo Zanoni Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch