From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 9/9] drm/i915: create the DDI encoder Date: Tue, 30 Oct 2012 22:36:58 +0100 Message-ID: <20121030213658.GD5755@phenom.ffwll.local> References: <1351285552-4156-1-git-send-email-przanoni@gmail.com> <1351285552-4156-10-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 5EE6AA0A79 for ; Tue, 30 Oct 2012 14:35:53 -0700 (PDT) Received: by mail-ee0-f49.google.com with SMTP id c1so422334eek.36 for ; Tue, 30 Oct 2012 14:35:52 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Damien Lespiau Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Tue, Oct 30, 2012 at 12:51:11PM +0000, Damien Lespiau wrote: > On Fri, Oct 26, 2012 at 10:05 PM, Paulo Zanoni wrote: > > From: Paulo Zanoni > > > > Now intel_ddi_init is just like intel_hdmi_init and intel_dp_init: it > > inits the encoder and then calls the proper init_connector functions. > > Notice that for non-eDP ports we call both HDMI and DP connector init, > > so we have 2 connectors attached to each DDI encoder. > > > > After this change, intel_hdmi_init and intel_dp_init are only called > > by Ivy Bridge and earlier, while hardware containing DDI outputs > > should call intel_ddi_init. > > > > Also added/removed quite a few "static" keywords due to the fact that > > some function pointers were moved from intel_dp.c and intel_hdmi.c to > > intel_ddi.c. > > > > DP finally works on Haswell now! \o/ > > > > Signed-off-by: Paulo Zanoni > > Reviewed-by: Damien Lespiau All merged to dinq, thanks for patches and review. There was a strange patch conflict on the last one (I couldn't figure out what actually conflicted), please check whether I haven't broken anything. Yours, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch