From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 6/9 v3] drm/i915: Stop using AGP layer for GEN6+ Date: Wed, 31 Oct 2012 10:57:08 +0100 Message-ID: <20121031095708.GF5755@phenom.ffwll.local> References: <1351284864-3555-1-git-send-email-ben@bwidawsk.net> <1351476536-4056-1-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 340B19E9FF for ; Wed, 31 Oct 2012 02:56:04 -0700 (PDT) Received: by mail-ee0-f49.google.com with SMTP id c1so635434eek.36 for ; Wed, 31 Oct 2012 02:56:03 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1351476536-4056-1-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Sun, Oct 28, 2012 at 07:08:56PM -0700, Ben Widawsky wrote: > As a quick hack we make the old intel_gtt structure mutable so we can > fool a bunch of the existing code which depends on elements in that data > structure. We can/should try to remove this in a subsequent patch. > > This should preserve the old gtt init behavior which upon writing these > patches seems incorrect. The next patch will fix these things. > > The one exception is VLV which doesn't have the preserved flush control > write behavior. Since we want to do that for all GEN6+ stuff, we'll > handle that in a later patch. Mainstream VLV support doesn't actually > exist yet anyway. > > v2: Update the comment to remove the "voodoo" > Check that the last pte written matches what we readback > > v3: actually kill cache_level_to_agp_type since most of the flags will > dissapear in an upcoming patch > > Signed-off-by: Ben Widawsky Just wanted to merge this entire pile, but then stumbled over a small thing: You can't kill the cache_level_to_agp_type stuff, since we now have different cache levels even on pre-gen6. Otherwise you'll break cacheable bos in SNA, which will anger Chris ;-) Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch