From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: move encoder->mode_set calls to crtc_mode_set Date: Thu, 1 Nov 2012 09:15:33 +0100 Message-ID: <20121101081533.GM5755@phenom.ffwll.local> References: <1351707973-1049-1-git-send-email-daniel.vetter@ffwll.ch> <84c8a8$6bpsjj@orsmga001.jf.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 5B3559E78C for ; Thu, 1 Nov 2012 01:14:27 -0700 (PDT) Received: by mail-ee0-f49.google.com with SMTP id c1so1155815eek.36 for ; Thu, 01 Nov 2012 01:14:26 -0700 (PDT) Content-Disposition: inline In-Reply-To: <84c8a8$6bpsjj@orsmga001.jf.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: Daniel Vetter , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Wed, Oct 31, 2012 at 10:46:36PM +0000, Chris Wilson wrote: > On Wed, 31 Oct 2012 19:26:13 +0100, Daniel Vetter wrote: > > Makes more sense to group the entire mode_set stage into one function. > > Noticed while discussiing the rather confusing set of function names > > with Paulo Zanoni. Unfortunately I don't have an idea to make the > > function names lesss confusion. > > > > v2: Use for_each_encoder_on_crtc as suggested by Chris Wilson. > > > > Signed-off-by: Daniel Vetter > > Just a simple piece of code movement, with a sprinkling of sugar on top. > Reviewed-by: Chris Wilson Queued for -next, thanks for the review. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch