From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 01/11] drm/i915: Fix display pixel format handling Date: Thu, 1 Nov 2012 16:03:13 +0200 Message-ID: <20121101140313.GL3791@intel.com> References: <1351698624-26626-1-git-send-email-ville.syrjala@linux.intel.com> <1351698624-26626-2-git-send-email-ville.syrjala@linux.intel.com> <20121031132023.7a493641@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id E169D9E968 for ; Thu, 1 Nov 2012 07:03:17 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20121031132023.7a493641@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Oct 31, 2012 at 01:20:23PM -0700, Jesse Barnes wrote: > On Wed, 31 Oct 2012 17:50:14 +0200 > ville.syrjala@linux.intel.com wrote: > = > > From: Ville Syrj=E4l=E4 > > = > > Fix support for all RGB/BGR pixel formats (except the 16:16:16:16 float > > format). > > = > > Fix intel_init_framebuffer() to match hardware and driver limitations: > > * RGB332 is not supported at all > > * CI8 is supported > > * XRGB1555 & co. are supported on Gen3 and earlier > > * XRGB210101010 & co. are supported from Gen4 onwards > > * BGR formats are supported from Gen4 onwards > > * YUV formats are supported from Gen5 onwards (driver limitation) > = > Yeah looks nice. I love how our definitions have the component order > reversed relative to the fourcc-ish codes. Yeah. I just copied the names more or less blindly from the spec. I usually prefer to keep register definitons and specs in sync, since it makes it easier to search for stuff in the spec. But if people are bothered by this mess, I won't object to changing the defns to match the fourcc stuff. -- = Ville Syrj=E4l=E4 Intel OTC