From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 31/36] drm/i915: don't assert_pch_ports_disabled on LPT Date: Thu, 1 Nov 2012 17:21:20 +0100 Message-ID: <20121101162120.GZ5755@phenom.ffwll.local> References: <1351714375-15284-1-git-send-email-przanoni@gmail.com> <1351714375-15284-32-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f177.google.com (mail-ea0-f177.google.com [209.85.215.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 7DA359EFBB for ; Thu, 1 Nov 2012 09:20:14 -0700 (PDT) Received: by mail-ea0-f177.google.com with SMTP id n13so1059849eaa.36 for ; Thu, 01 Nov 2012 09:20:13 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1351714375-15284-32-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Wed, Oct 31, 2012 at 06:12:50PM -0200, Paulo Zanoni wrote: > From: Paulo Zanoni > > That function is made for IBX. Running it on LPT will trigger tons of > "unclaimed register" errors. The only port remaining on LPT is > PCH_ADPA. > > Signed-off-by: Paulo Zanoni Actually I've had to stay around for a while longer before heading off, so reviewed and applied a few more patches, up to this one here (minus the one I've dropped). Thanks, Daniel > --- > drivers/gpu/drm/i915/intel_display.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index 10ea4f5..7d858f8 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -1775,9 +1775,6 @@ static void lpt_disable_pch_transcoder(struct drm_i915_private *dev_priv, > assert_fdi_tx_disabled(dev_priv, pipe); > assert_fdi_rx_disabled(dev_priv, pipe); > > - /* Ports must be off as well */ > - assert_pch_ports_disabled(dev_priv, pipe); > - > reg = TRANSCONF(pipe); > val = I915_READ(reg); > val &= ~TRANS_ENABLE; > -- > 1.7.11.4 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch