From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH 4/4] drm/i915: don't rewrite the GTT on
 resume v3
Date: Fri, 2 Nov 2012 09:40:47 -0700
Message-ID: <20121102094047.7292a96a@jbarnes-desktop>
References: <1351723265-4086-1-git-send-email-jbarnes@virtuousgeek.org>
	<1351723265-4086-4-git-send-email-jbarnes@virtuousgeek.org>
	<eeac1e$4s7bs7@AZSMGA002.ch.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from oproxy6-pub.bluehost.com (oproxy6-pub.bluehost.com
	[67.222.54.6])
	by gabe.freedesktop.org (Postfix) with SMTP id C4F9EA10A3
	for <intel-gfx@lists.freedesktop.org>;
	Fri,  2 Nov 2012 09:40:43 -0700 (PDT)
In-Reply-To: <eeac1e$4s7bs7@AZSMGA002.ch.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Fri, 02 Nov 2012 15:16:36 +0000
Chris Wilson <chris@chris-wilson.co.uk> wrote:

> On Wed, 31 Oct 2012 15:41:05 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > The BIOS shouldn't be touching this memory across suspend/resume, so
> > just leave it alone.  This saves us ~6ms on resume on my T420 (retested
> > with write combined PTEs).
> > 
> > v2: change gtt restore default on pre-gen4 (Chris)
> >     move needs_gtt_restore flag into dev_priv
> > v3: make sure we restore GTT on resume from hibernate (Daniel)
> >     use opregion support as the cutoff for restore from resume (Chris)
> > 
> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> 
> My troublesome PNV of yore remains happy with this patch, so
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> 
> Bikeshed: intel_bios_has_opregion(), as we test for this in different
> locations in different ways.
> -Chris
> 

Ended up using dev_priv->opregion.header as the check, seems simplier.

Integrated your other comments and reposted a new series.

-- 
Jesse Barnes, Intel Open Source Technology Center