From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 4/4] drm/i915: don't rewrite the GTT on resume v4 Date: Fri, 2 Nov 2012 23:55:04 +0100 Message-ID: <20121102225504.GN5755@phenom.ffwll.local> References: <1351880042-24935-1-git-send-email-jbarnes@virtuousgeek.org> <1351880042-24935-4-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f177.google.com (mail-ea0-f177.google.com [209.85.215.177]) by gabe.freedesktop.org (Postfix) with ESMTP id A7D419E7B2 for ; Fri, 2 Nov 2012 15:53:58 -0700 (PDT) Received: by mail-ea0-f177.google.com with SMTP id n13so1571400eaa.36 for ; Fri, 02 Nov 2012 15:53:58 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1351880042-24935-4-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Nov 02, 2012 at 11:14:02AM -0700, Jesse Barnes wrote: > The BIOS shouldn't be touching this memory across suspend/resume, so > just leave it alone. This saves us ~6ms on resume on my T420 (retested > with write combined PTEs). > > v2: change gtt restore default on pre-gen4 (Chris) > move needs_gtt_restore flag into dev_priv > v3: make sure we restore GTT on resume from hibernate (Daniel) > use opregion support as the cutoff for restore from resume (Chris) > v4: use a better check for opregion (Chris) > > Reviewed-by: Chris Wilson > Signed-off-by: Jesse Barnes Merged, with some bikeshed applied, and the less-than-careful locking switch in patch 3 fixed. Please check whether I haven't botched it up. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch