From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH] intel: Fix missing ETIME on BSD operating systems Date: Sun, 11 Nov 2012 09:26:19 -0800 Message-ID: <20121111092619.00004321@unknown> References: <1352525096-10345-1-git-send-email-ryao@cs.stonybrook.edu> <87ip9d1al2.fsf@eliezer.anholt.net> <509EC8DA.4050205@gentoo.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from shiva.chad-versace.us (209-20-75-48.static.cloud-ips.com [209.20.75.48]) by gabe.freedesktop.org (Postfix) with ESMTP id A846C9EF1F for ; Sun, 11 Nov 2012 09:26:43 -0800 (PST) In-Reply-To: <509EC8DA.4050205@gentoo.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Richard Yao Cc: gentoo-bsd@lists.gentoo.org, intel-gfx@lists.freedesktop.org, x11@freebsd.org, David Shao List-Id: intel-gfx@lists.freedesktop.org On Sat, 10 Nov 2012 16:36:26 -0500 Richard Yao wrote: > On 11/10/2012 03:12 PM, Eric Anholt wrote: > > Richard Yao writes: > > > >> From: David Shao > >> > >> Originally posted to Free Desktop bug #52549 by David Shao. > >> Resolves Gentoo Bug #433403. > >> Commit message by Richard Yao. > > > > Are you really unable to get the same errnos in your port of the > > kernel modules? Having mismatched errno returns from upstream is a > > great way to have obscure bugs on your port, given that our kernel > > guys like to look for alternative errnos to be able to distinguish > > failure modes from userland. > > > > I don't like the idea of this patch landing. > > I have added the FreeBSD x11 team alias to CC, which I probably should > have done in my original email. They are in a better position to > answer this than I am. > > At present, MySQL also does this. Changing that would require changes > to the userland of FreeBSD (and other BSDs). The FreeBSD x11 team is > in a position to do that. I am in the process of getting Gentoo's X11 > stack working on Gentoo FreeBSD, so I am interested in their answer > to your question as well. > > Before pushing the patch, I did a bit of googling and I too found that MySQL and LibreOffice does this, so it seemed okay to me. It's not terribly prolific because I think many cross-platform products do not use interfaces which return ETIME. It sounds like BSD though is the only remaining holdout, as Windows and OSX both seem to support ETIME.