From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH] drm/i915: Report amount of usable graphics
 memory in MiB
Date: Sun, 11 Nov 2012 10:34:23 -0800
Message-ID: <20121111103423.00006c44@unknown>
References: <1352626485-14742-1-git-send-email-chris@chris-wilson.co.uk>
	<20121111093406.0000262c@unknown>
	<20121111174855.GL5854@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from shiva.chad-versace.us (209-20-75-48.static.cloud-ips.com
	[209.20.75.48])
	by gabe.freedesktop.org (Postfix) with ESMTP id ED6AE9E9E3
	for <intel-gfx@lists.freedesktop.org>;
	Sun, 11 Nov 2012 10:34:37 -0800 (PST)
In-Reply-To: <20121111174855.GL5854@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Sun, 11 Nov 2012 18:48:55 +0100
Daniel Vetter <daniel@ffwll.ch> wrote:

> On Sun, Nov 11, 2012 at 09:34:06AM -0800, Ben Widawsky wrote:
> > On Sun, 11 Nov 2012 09:34:45 +0000
> > Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > 
> > > ...rather than kilo-PTE.
> > > 
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > ---
> > >  drivers/gpu/drm/i915/i915_gem_gtt.c |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> > > index e7515e8..938710a 100644
> > > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> > > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> > > @@ -708,7 +708,7 @@ int i915_gem_gtt_init(struct drm_device *dev)
> > >  	}
> > >  
> > >  	/* GMADR is the PCI aperture used by SW to access tiled GFX surfaces in a linear fashion. */
> > > -	DRM_INFO("Memory Usable by graphics device = %dK\n", dev_priv->mm.gtt->gtt_total_entries >> 10);
> > > +	DRM_INFO("Memory Usable by graphics device = %dM\n", dev_priv->mm.gtt->gtt_total_entries >> 8);
> > >  	DRM_DEBUG_DRIVER("GMADR size = %dM\n", dev_priv->mm.gtt->gtt_mappable_entries >> 8);
> > >  	DRM_DEBUG_DRIVER("GTT stolen size = %dM\n", dev_priv->mm.gtt->stolen_size >> 20);
> > >  
> > 
> > Shouldn't it be >> 18 though, not >> 8?
> 
> Each pte entry stands for a 4k page, so entries is already size >> 12, so
> we only need to shift by 8 to get M. Patch merged to dinq.
> -Daniel

Looking through the code it didn't seem to match what you're saying,
but I do agree, it's ((total entries << 12)) >> 20) which is total
entries >> 8. I've verified it too on my machine. I'll blame it on a
lack of caffeine.

Please make "usable" lower case while you're at it.