From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josh Triplett Subject: Re: [PATCH] drm/i915: add LynxPoint-LP PCH ID Date: Mon, 12 Nov 2012 15:24:29 -0800 Message-ID: <20121112232429.GA18140@jtriplet-mobl1> References: <1352753653-3559-1-git-send-email-przanoni@gmail.com> <20121112230453.GQ5854@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from slow3-v.mail.gandi.net (slow3-v.mail.gandi.net [217.70.178.89]) by gabe.freedesktop.org (Postfix) with ESMTP id 5C4489E821 for ; Mon, 12 Nov 2012 15:26:29 -0800 (PST) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by slow3-v.mail.gandi.net (Postfix) with ESMTP id 8E7A53AA81 for ; Tue, 13 Nov 2012 00:24:36 +0100 (CET) Content-Disposition: inline In-Reply-To: <20121112230453.GQ5854@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Wei Shun Chang , intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Tue, Nov 13, 2012 at 12:04:53AM +0100, Daniel Vetter wrote: > On Mon, Nov 12, 2012 at 06:54:13PM -0200, Paulo Zanoni wrote: > > From: Wei Shun Chang > > > > [pzanoni: rebase, print it's an LP PCH] > > > > Signed-off-by: Paulo Zanoni > > --- > > drivers/gpu/drm/i915/i915_drv.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > > > I can't test the patch since I don't have the LP PCH. > > Including Josh, since he has such a machine. Tested-by: Josh Triplett With this patch, I can boot and run on such a board. I do get an odd kernel gripe, though: "More than 8 outputs detected". > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > > index f8ba5fe..418d17c 100644 > > --- a/drivers/gpu/drm/i915/i915_drv.c > > +++ b/drivers/gpu/drm/i915/i915_drv.c > > @@ -394,6 +394,7 @@ MODULE_DEVICE_TABLE(pci, pciidlist); > > #define INTEL_PCH_CPT_DEVICE_ID_TYPE 0x1c00 > > #define INTEL_PCH_PPT_DEVICE_ID_TYPE 0x1e00 > > #define INTEL_PCH_LPT_DEVICE_ID_TYPE 0x8c00 > > +#define INTEL_PCH_LPT_LP_DEVICE_ID_TYPE 0x9c00 > > > > void intel_detect_pch(struct drm_device *dev) > > { > > @@ -433,6 +434,11 @@ void intel_detect_pch(struct drm_device *dev) > > dev_priv->num_pch_pll = 0; > > DRM_DEBUG_KMS("Found LynxPoint PCH\n"); > > WARN_ON(!IS_HASWELL(dev)); > > + } else if (id == INTEL_PCH_LPT_LP_DEVICE_ID_TYPE) { > > + dev_priv->pch_type = PCH_LPT; > > + dev_priv->num_pch_pll = 0; > > + DRM_DEBUG_KMS("Found LynxPoint LP PCH\n"); > > + WARN_ON(!IS_HASWELL(dev)); > > } > > BUG_ON(dev_priv->num_pch_pll > I915_NUM_PLLS); > > } > > -- > > 1.7.10.4 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > -- > Daniel Vetter > Software Engineer, Intel Corporation > +41 (0) 79 365 57 48 - http://blog.ffwll.ch