From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Check for a change in fb size, and reconfigure the pipe Date: Tue, 13 Nov 2012 15:59:46 +0200 Message-ID: <20121113135946.GJ3791@intel.com> References: <1352808910-31946-1-git-send-email-chris@chris-wilson.co.uk> <20121113124236.GH3791@intel.com> <20121113131555.GI3791@intel.com> <275ffc$7crnav@fmsmga002.fm.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by gabe.freedesktop.org (Postfix) with ESMTP id C1E3D9F378 for ; Tue, 13 Nov 2012 06:00:02 -0800 (PST) Content-Disposition: inline In-Reply-To: <275ffc$7crnav@fmsmga002.fm.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Nov 13, 2012 at 01:33:37PM +0000, Chris Wilson wrote: > On Tue, 13 Nov 2012 15:15:55 +0200, Ville Syrj=E4l=E4 wrote: > > On Tue, Nov 13, 2012 at 12:48:11PM +0000, Chris Wilson wrote: > > > On Tue, 13 Nov 2012 14:42:36 +0200, Ville Syrj=E4l=E4 wrote: > > > > On Tue, Nov 13, 2012 at 12:15:10PM +0000, Chris Wilson wrote: > > > > > In the slightly unusual case where the pipe is programmed to the = same > > > > > modeline, but the framebuffer is a new size, we need to resetup t= he > > > > > panel fitter as appropriate and this requires a full modeset. Thi= s can > > > > > only occur currently as part of the BIOS takeover where there are > > > > > slightly different semantics governing how the panel fitter and > > > > > framebuffer is programmed relative to the modeline. > > > > = > > > > Hmm. I don't get it. Why would the framebuffer size affect the panel > > > > fitter configuration? > > > = > > > The BIOS uses fb->(width,height) to program PIPESRC, we use > > > mode->[hv]display. The BIOS's semantics makes more sense > > = > > I don't think so. That would make panning impossible. > = > True. The issue really appears that we recreate the mode using the crtc > values and assume that the reverse mapping works. Further issues arise > if we want to recover any offsets in a multiple output configuration. I > will just have to double-check that the BIOS configuration matches our > usage. > = > And I whole-heartedly agree with separating the display mode from the > plane configuration, I guess you have something planned along those > lines already ;-) Well, I have some ideas in my head, but so far I haven't found the time to do the work. Originally I was thinking that I'd try to combine this work with the atomic mode setting, but I fear that if I keep piling on more changes, it'll never be ready. -- = Ville Syrj=E4l=E4 Intel OTC